Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent multiple websocket frames from being demanded in Jetty-12 #9965

Closed
lachlan-roberts opened this issue Jun 26, 2023 · 0 comments
Closed
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version(s)
12

Description
After PR #9945 you can no longer demand multiple frames at once.
We should remove the internal counter tracking demand and throw ISE or ReadPending exception if multiple frames are demanded.

ie. this code should be throwing ISE but instead it is just incrementing the internal demand counter.

for (long i = 0; i < n; i++)
           demand();
@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Jun 26, 2023
@lachlan-roberts lachlan-roberts self-assigned this Jun 27, 2023
lachlan-roberts added a commit that referenced this issue Jun 27, 2023
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

No branches or pull requests

1 participant