Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement logic for Configuration lists #10081

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

janbartel
Copy link
Contributor

jetty-12 ee10

When a list of Configuration classes was passed to the Configurations(List<Configuration>) constructor, it was not processing the list for replacements.

@janbartel janbartel added Bug For general bugs on Jetty side Jetty 12 labels Jul 7, 2023
@janbartel janbartel requested a review from gregw July 7, 2023 10:27
@janbartel janbartel self-assigned this Jul 7, 2023
gregw
gregw previously approved these changes Jul 7, 2023
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a comment about why would be nice.

@janbartel janbartel merged commit e22fbbf into jetty-12.0.x Jul 8, 2023
@joakime joakime changed the title Fix configuration replacement Fix replacement logic for Configuration lists Jul 27, 2023
@joakime joakime deleted the jetty-12.0.x-config-replacement branch August 7, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants