Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #10274 - Improve javadoc + move internal methods #10276

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Issue #10274 - Improve javadoc + move internal methods #10276

merged 5 commits into from
Aug 16, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Aug 9, 2023

Attempt to improve the javadoc experience with Resource and ResourceFactory use.

@joakime joakime requested a review from sbordet August 9, 2023 13:13
@joakime joakime self-assigned this Aug 9, 2023
@joakime joakime added this to the 12.0.x milestone Aug 9, 2023
@joakime joakime linked an issue Aug 9, 2023 that may be closed by this pull request
java.nio.file.FileSystemNotFoundException when creating a resource from a JAR URL #10274
Closed
@joakime joakime mentioned this pull request Aug 9, 2023
Closed
@joakime joakime marked this pull request as ready for review August 9, 2023 15:40
sbordet
sbordet requested changes Aug 11, 2023
View reviewed changes
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactory.java Outdated Show resolved Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactory.java Outdated Show resolved Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactory.java Outdated Show resolved Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactory.java Outdated Show resolved Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactory.java Outdated Show resolved Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactory.java Outdated Show resolved Hide resolved
@joakime joakime requested a review from sbordet August 14, 2023 17:54
gregw
gregw requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is a general improvement, but it is highlighting that we still have some big issues in our resource abstraction. Can we schedule a hangout to discuss?

jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactory.java Outdated Show resolved Hide resolved
...-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactoryInternals.java Outdated Show resolved Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/URIUtil.java Show resolved Hide resolved
@joakime joakime requested a review from gregw August 15, 2023 23:12
@joakime
Copy link
Contributor Author

joakime commented Aug 15, 2023

@gregw I think I've addressed your last review.

@joakime
Copy link
Contributor Author

joakime commented Aug 16, 2023

@sbordet bump, your out of date change request is blocking this merge.

@joakime
Copy link
Contributor Author

joakime commented Aug 16, 2023

This javadoc will need more iterations, but this feels like a step in the right direction (at least).

@joakime joakime merged commit fd1413d into jetty-12.0.x Aug 16, 2023
2 checks passed
@joakime joakime deleted the fix/12.0.x/resources-javadoc branch August 16, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

@gregw gregw gregw approved these changes

Assignees

@joakime joakime

Labels
Documentation Enhancement
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.

java.nio.file.FileSystemNotFoundException when creating a resource from a JAR URL
3 participants
@joakime @gregw @sbordet