Allow session idle timeout to be configured on authentication. #10511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow session idle timeout to be configured on authentication. Signed-off-by: gregw <gregw@webtide.com>
janbartel
requested changes
Sep 14, 2023
| @@ -68,7 +68,8 @@ public abstract class SecurityHandler extends HandlerWrapper implements Authenti | |||
| private final Map<String, String> _initParameters = new HashMap<>(); | |||
| private LoginService _loginService; | |||
| private IdentityService _identityService; | |||
| private boolean _renewSession = true; | |||
| private boolean _renewSessionOnAuthentication = true; | |||
| private int _sessionMaxInactiveIntervalOnAuthentication = 0; | |||
There was a problem hiding this comment.
I don't think a default of 0 is a good idea. If it is not set, then sessions that were previously configured - either programmatically or via web.xml - to timeout after x minutes are suddenly immortal after authentication.
Ooops, commented too soon. Now I've read the LoginAuthenticator code and it's the other way around: you can't cause sessions to become immortal after being authenticated. Immortality is indicated by a timeout <= 0, but you're only setting the maxInactiveInterval iff it's > 0.
There was a problem hiding this comment.
I've updated so that non-zero values are set on authentication, so we can now make a session immortal on authentication with a value of -1.
jetty-security/src/main/java/org/eclipse/jetty/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
jetty-security/src/main/java/org/eclipse/jetty/security/Authenticator.java
Show resolved
Hide resolved
jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Show resolved
Hide resolved
jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Show resolved
Hide resolved
jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Show resolved
Hide resolved
jetty-security/src/main/java/org/eclipse/jetty/security/WrappedAuthConfiguration.java
Show resolved
Hide resolved
Signed-off-by: gregw <gregw@webtide.com>
janbartel
previously approved these changes
Sep 15, 2023
jetty-security/src/main/java/org/eclipse/jetty/security/authentication/LoginAuthenticator.java
Outdated
Show resolved
Hide resolved
jetty-security/src/test/java/org/eclipse/jetty/security/ConstraintTest.java
Outdated
Show resolved
Hide resolved
jetty-security/src/test/java/org/eclipse/jetty/security/ConstraintTest.java
Outdated
Show resolved
Hide resolved
jetty-security/src/test/java/org/eclipse/jetty/security/ConstraintTest.java
Show resolved
Hide resolved
Signed-off-by: gregw <gregw@webtide.com>
janbartel
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow session idle timeout to be configured on authentication.