Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of Objects in JMX MetaData #10762

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Better handling of Objects in JMX MetaData #10762

merged 3 commits into from
Oct 23, 2023

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Oct 20, 2023

No description provided.

@gregw gregw requested a review from sbordet October 20, 2023 03:56
@gregw
Copy link
Contributor Author

gregw commented Oct 20, 2023

@sbordet This approach works for most of the failing attributes. Only Maps and/or Attributes are not working.... I had a try, but ran out of time to make it work. Feel free to take over

@gregw gregw marked this pull request as ready for review October 20, 2023 21:52
@gregw
Copy link
Contributor Author

gregw commented Oct 20, 2023

@sbordet I couldn't get CompositeData to work, so for now I'm sending Attributes as Map<String,String>

@sbordet
* JMX-annotated ErrorHandler, fixed usage of showMessageInTitle and r…
5ac408f 
…emoved showServlet.

* JMX-annotated Request.Handler.
* Added JMX test module to test improvements to JMX.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
sbordet approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregw I added test cases, now good coverage for the MetaData class and the changes you made.
LGTM.

@gregw
Copy link
Contributor Author

gregw commented Oct 23, 2023

The CI failures are unrelated. I am merging.

@gregw gregw merged commit 14152c4 into jetty-12.0.x Oct 23, 2023
3 of 4 checks passed
@gregw gregw deleted the experiment/12/jmxObjectNames branch October 23, 2023 23:03
@sbordet sbordet linked an issue Oct 24, 2023 that may be closed by this pull request
Jetty 12: Review MBeans for Handlers #10477
Closed
@sbordet sbordet mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 12.0.3 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jetty 12: Review MBeans for Handlers
2 participants
@gregw @sbordet