Update jetty-maven-plugin.adoc #10810
Conversation
Update Jetty maven plugin for Jetty 12.
|
fix #10809 |
...tation/jetty-documentation/src/main/asciidoc/programming-guide/maven/jetty-maven-plugin.adoc
Outdated
Show resolved
Hide resolved
...tation/jetty-documentation/src/main/asciidoc/programming-guide/maven/jetty-maven-plugin.adoc
Outdated
Show resolved
Hide resolved
|
@olamy The doc is updated, please check it. |
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> | ||
| <groupId>org.eclipse.jetty.ee{8,9,10}</groupId> | ||
| <artifactId>jetty-ee{8,9,10}-maven-plugin</artifactId> |
There was a problem hiding this comment.
I understand what you're trying to do here, but you won't believe how many people simply cut and paste from the documentation into their pom and then complain it doesn't work. So I think its fine to have {8,9,10} in the body of the text, but any example should refer to ee10 only. So this example (and all others) would be:
<groupId>org.eclipse.jetty.ee10</groupId>
<artifactId>jetty-ee10-maven-plugin</artifactId>There was a problem hiding this comment.
There are several ee{8,9,10}, we need replace all of them to ee10(as the initial version)?
There was a problem hiding this comment.
Really, I'm not kidding when I say people just cut and paste from the documentation without reading properly or engaging their critical faculties :)
There was a problem hiding this comment.
I think it's important to preface each example with your {8,9,10} comment, and say that the example shows how to do it for ee10.
...tation/jetty-documentation/src/main/asciidoc/programming-guide/maven/jetty-maven-plugin.adoc
Outdated
Show resolved
Hide resolved
...tation/jetty-documentation/src/main/asciidoc/programming-guide/maven/jetty-maven-plugin.adoc
Outdated
Show resolved
Hide resolved
…g-guide/maven/jetty-maven-plugin.adoc Co-authored-by: Jan Bartel <janb@webtide.com>
…g-guide/maven/jetty-maven-plugin.adoc Co-authored-by: Jan Bartel <janb@webtide.com>
|
@hantsy Thanks for your contribution |
Update Jetty maven plugin for Jetty 12.