Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ee10-jndi-demo #10858

Closed
wants to merge 3 commits into from
Closed

Fix ee10-jndi-demo #10858

wants to merge 3 commits into from

Conversation

janbartel
Copy link
Contributor

Some of the xml files related to the ee10-jndi-demo were not ported to ee10, but only affects running with the jetty maven plugin.

@janbartel janbartel requested a review from olamy November 6, 2023 22:31
olamy
olamy approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (might be a bit of work to have distribution test with a database)

@janbartel
Copy link
Contributor Author

The changes in this PR have been rolled into #10897, so I'll close this if the other one gets approved.

@janbartel
Copy link
Contributor Author

Closed in favour of #10897

@janbartel janbartel closed this Dec 5, 2023
@janbartel janbartel deleted the jetty-12.0.x-fix-ee10-jndi-demo branch December 5, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janbartel @olamy @joakime