reinstate HttpChannel reuse in H2 #10868
Conversation
…0.x/h2ReuseHttpChannels
...ttp2-server/src/main/java/org/eclipse/jetty/http2/server/internal/HTTP2ServerConnection.java
Show resolved
Hide resolved
| } | ||
|
|
||
| private HttpChannelOverHTTP2 pollHttpChannel() | ||
| public void setRecycleHttpChannels(boolean recycleHttpChannels) |
There was a problem hiding this comment.
This config needs to be wired?
There was a problem hiding this comment.
Again, I took this from the commented out previous implementation. I think it can be permanently on and not wired into config. It is only there as an option in case we suspect a problem.
There was a problem hiding this comment.
But if it's not wired, it's useless as there is no way a user can enable it, and we can easily remove this recycling logic locally if we ever suspect it's causing problems and are working on reproducing the issue.
I think this boolean should just go and have the queue logic always on.
There was a problem hiding this comment.
@lorban I think it needs to be restored, so it will be easier to performance test the effect of recycling channels.
For a benchmark we can subclass HTTP2ServerConnectionFactory.newConnection() and explicitly call the boolean setter on the HTTP2Connection.
|
@lorban I won't have time to land this one before vacation, so I'm "donating" it to you to complete. |
|
@gregw sure, I'm taking over this PR. |
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…0.x/h2ReuseHttpChannels
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
reinstate HttpChannel reuse in H2