Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10919 - EE10 multipart parsing may include '\r' at the front under certain conditions #10921

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fixes #10919 - EE10 multipart parsing may include '\r' at the front under certain conditions #10921

merged 4 commits into from
Nov 29, 2023

Commits on Nov 26, 2023

  1. Fixes #10919 - EE10 multipart parsing may include '\r' at the front u… 

    …nder certain conditions.

Setting MultiPart.Parser.crContent=false when the boundary is matched.
This is necessary when a read chunk ends with \r\n, and then matches the boundary on the next read chunk, and avoids to emit the CR as part content.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    994e100 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Fixed case of a chunk ending with \r. 

    Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4b8dad8 View commit details
    Browse the repository at this point in the history

  2. Factored out common code. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3d9aec3 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Fixed case where a CR in a previous chunk is followed by a boundary a… 

    …t index 0 in the next chunk.

The CR should not be emitted as content, and crContent reset to false.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6a1e352 View commit details
    Browse the repository at this point in the history