Fixes #11031 - HttpClient should expose Connection/EndPoint used by H… #11033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TTP requests. Introduced method Request.getConnection() to expose the Connection after at the request begin event. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
added
the
Sponsored
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
requested changes
Dec 11, 2023
| * or {@code null} if there is no connection associated | ||
| * with this request | ||
| */ | ||
| default Connection getConnection() |
There was a problem hiding this comment.
Why mark that method as default?
There was a problem hiding this comment.
Because it is an existing interface that people may have implemented (e.g. for wrapping), and we don't want to break them.
| /** | ||
| * @return the local socket address associated with the connection | ||
| */ | ||
| default SocketAddress getLocalSocketAddress() |
There was a problem hiding this comment.
Why mark that method as default?
| /** | ||
| * @return the remote socket address associated with the connection | ||
| */ | ||
| default SocketAddress getRemoteSocketAddress() |
There was a problem hiding this comment.
Why mark that method as default?
lorban
approved these changes
Dec 11, 2023
gregw
approved these changes
Dec 13, 2023
olamy
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…TTP requests.
Introduced method Request.getConnection() to expose the Connection after at the request begin event.