Issue #11296 Fix javadoc on AbstractLoginModule #11297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Jan 22, 2024
Comment on lines
38
to
39
| * implement getUser method, and subclass JAASUser to implement | ||
| * doFetchRoles method. |
There was a problem hiding this comment.
Please use {@link} to refer to the methods, so that users would be able to follow the links, and we will be sure that method renaming will automatically fix the javadocs.
olamy
approved these changes
Jan 24, 2024
joakime
deleted the
jetty-12.0.x-11296-fix-javadoc-AbstractLoginModule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11296
fix javadoc