Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SizeLimitHandler with fixes needed for appengine tests #11570

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

lachlan-roberts
Copy link
Contributor

various fixes to SizeLimitHandler were needed for appengine-java-standard which is now temporarily using a patched copy of this class to get the tests passing.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts added the Sponsored This issue affects a user with a commercial support agreement label Mar 26, 2024
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of niggles

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joakime joakime merged commit 0c14484 into jetty-12.0.x Apr 24, 2024
10 checks passed
@joakime joakime deleted the jetty-12.0.x-sizeLimitHandlerUpdate branch April 24, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants