Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #11847 implement environment context xml #11859

Merged
merged 8 commits into from
Jun 19, 2024

Conversation

janbartel
Copy link
Contributor

Closes #11847

@janbartel janbartel requested a review from gregw May 31, 2024 00:49
@janbartel janbartel self-assigned this May 31, 2024
@sbordet
Copy link
Contributor

sbordet commented May 31, 2024

@janbartel I just filed #11861.

I think this PR and #11861 are orthogonal, but just wanted to double-check that if either is implemented, it won't step on the toes of the other.

@janbartel
Copy link
Contributor Author

@janbartel I just filed #11861.

I think this PR and #11861 are orthogonal, but just wanted to double-check that if either is implemented, it won't step on the toes of the other.

I think the 2 can co-exist. It's not mandatory to have a core.properties file that defines the location of a context xml file to apply to all core deployments. And if you do define one, it should be fine to apply it along with any other context xml file defined for the "core webapp" either inside or outside the archive.

@janbartel
Copy link
Contributor Author

@gregw nudge

@gregw gregw requested a review from sbordet June 11, 2024 02:12
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's add one more feature to better support derived classes

@janbartel janbartel requested a review from gregw June 12, 2024 08:07
@janbartel janbartel merged commit 6ee17f0 into jetty-12.0.x Jun 19, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.0.x-11847-global-context-deploy branch June 19, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

replacement for GlobalWebappConfigBinding
3 participants