Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment for aborting callbacks #11876

Closed
wants to merge 44 commits into from
Closed

Experiment for aborting callbacks #11876

wants to merge 44 commits into from

Commits on Jun 4, 2024

  1. Experiment for aborting callbacks

    @gregw
    gregw committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    eb1c9a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Experiment for aborting callbacks 

    WIP
    @gregw
    gregw committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    860fbd0 View commit details
    Browse the repository at this point in the history

  2. Experiment for aborting callbacks 

    WIP
    @gregw
    gregw committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f4955be View commit details
    Browse the repository at this point in the history

  3. add test for legacy wrapping callbacks 

    Signed-off-by: Ludovic Orban <lorban@bitronix.be>
    @lorban
    lorban committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0ec0052 View commit details
    Browse the repository at this point in the history

  4. add test fix in comment 

    Signed-off-by: Ludovic Orban <lorban@bitronix.be>
    @lorban
    lorban committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    dd4fa07 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Experiment for aborting callbacks 

    IteratingCallback reimplemented
    @gregw
    gregw committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4661e3c View commit details
    Browse the repository at this point in the history

  2. Experiment for aborting callbacks 

    IteratingCallback reimplemented
    @gregw
    gregw committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    abcc33c View commit details
    Browse the repository at this point in the history

  3. Experiment for aborting callbacks 

    testing abort in every ICB state.
    @gregw
    gregw committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    bcd888f View commit details
    Browse the repository at this point in the history

  4. Experiment for aborting callbacks 

    testing abort in every ICB state.
    @gregw
    gregw committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a80fbc8 View commit details
    Browse the repository at this point in the history

  5. Experiment for aborting callbacks 

    testing abort in every ICB state.
    @gregw
    gregw committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ad20143 View commit details
    Browse the repository at this point in the history

  6. minimal changes to fix IllegalArgumentException in SocketChannel.write() 

    Signed-off-by: Ludovic Orban <lorban@bitronix.be>
    @lorban
    lorban committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    46c6b2b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Experiment for aborting callbacks

    @gregw
    gregw committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    81b4227 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. updates from review

    @gregw
    gregw committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7b54c74 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. updates from review

    @gregw
    gregw committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7857422 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/jetty-12.0.x' into experiment/je… 

    …tty-12.0.x/11854/abortCallback
    @gregw
    gregw committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    31fd432 View commit details
    Browse the repository at this point in the history

  3. updates from review

    @gregw
    gregw committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    01846b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. WIP updates from review

    @gregw
    gregw committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    304aee1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/jetty-12.0.x' into experiment/je… 

    …tty-12.0.x/11854/abortCallback
    @gregw
    gregw committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    58c3e30 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. WIP updates from review

    @gregw
    gregw committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    dce7956 View commit details
    Browse the repository at this point in the history

  2. WIP updates from review

    @gregw
    gregw committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7099526 View commit details
    Browse the repository at this point in the history

  3. WIP updates from review

    @gregw
    gregw committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    10a7a8a View commit details
    Browse the repository at this point in the history

  4. WIP updates from review

    @gregw
    gregw committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c0beb52 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. WIP updates from review

    @gregw
    gregw committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6964fe6 View commit details
    Browse the repository at this point in the history

  2. Calling super.onCompleted() in Callback.Nested subclasses. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    879c341 View commit details
    Browse the repository at this point in the history

  3. Added TODOs in relevant places where abort needs to be handled. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7798d69 View commit details
    Browse the repository at this point in the history

  4. WIP updates from review 

    improved from methods
    @gregw
    gregw committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    881a450 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'jetty-12.0.x' into experiment/jetty-12.0.x/11854/abortC… 

    …allback
    @gregw
    gregw committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5da31e7 View commit details
    Browse the repository at this point in the history

  6. WIP updates from review

    @gregw
    gregw committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    841fefb View commit details
    Browse the repository at this point in the history

  7. fixed from tests

    @gregw
    gregw committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c6e3f09 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. fixed tests 

    Adapted for abort semantics
    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4b5d449 View commit details
    Browse the repository at this point in the history

  2. fixed Http2Flusher

    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    51d6984 View commit details
    Browse the repository at this point in the history

  3. fixed Http2Flusher

    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    1f72dcb View commit details
    Browse the repository at this point in the history

  4. WIP 

    Additional javadoc
cleanup from implementations
extra logging
    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    73f1177 View commit details
    Browse the repository at this point in the history

  5. Temporary fixes for aborting HttpSender.ContentSender 

    Do minimal abort handling
The class needs more detailed review
    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f1f396c View commit details
    Browse the repository at this point in the history

  6. Better javadoc in ICB 

    ICB.onAbort(Throwable) calls ICB.failed(Throwable) by default.
    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ca4356e View commit details
    Browse the repository at this point in the history

  7. Better javadoc in ICB 

    ICB.onAbort(Throwable) calls ICB.failed(Throwable) by default.
    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5cb8f8b View commit details
    Browse the repository at this point in the history

  8. Fixed ConnectHandler ICB usage 

    See #11932
    @gregw
    gregw committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    961393e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. merged from 12.0.x

    @gregw
    gregw committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    86b1989 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge branch 'jetty-12.0.x' into experiment/jetty-12.0.x/11854/abortC… 

    …allback
    @gregw
    gregw committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bfb91ac View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Merge remote-tracking branch 'origin/jetty-12.0.x' into experiment/je… 

    …tty-12.0.x/11854/abortCallback

# Conflicts:
#	jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ConnectHandler.java
#	jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/IteratingCallback.java
    @gregw
    gregw committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1810573 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/jetty-12.0.x' into experiment/je… 

    …tty-12.0.x/11854/abortCallback

# Conflicts:
#	jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ErrorHandler.java
#	jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/HttpOutput.java
#	jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/HttpOutput.java
    @gregw
    gregw committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0ffd645 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge remote-tracking branch 'origin/jetty-12.0.x' into experiment/je… 

    …tty-12.0.x/11854/abortCallback
    @gregw
    gregw committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6b979fd View commit details
    Browse the repository at this point in the history

  2. Fix ISE handling

    @gregw
    gregw committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c16059b View commit details
    Browse the repository at this point in the history

  3. added onFailure

    @gregw
    gregw committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e546948 View commit details
    Browse the repository at this point in the history