-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty 12.0.x object identity ee8 and ee9 #11888
Jetty 12.0.x object identity ee8 and ee9 #11888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly javadoc changes... but I have one concern about EE10 to EE9 dispatch session management.
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/ContextHandler.java
Show resolved
Hide resolved
...-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/CrossContextDispatcher.java
Outdated
Show resolved
Hide resolved
...-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/CrossContextDispatcher.java
Outdated
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/SessionHandler.java
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/SessionHandler.java
Show resolved
Hide resolved
…/nested/CrossContextDispatcher.java Co-authored-by: Greg Wilkins <gregw@webtide.com>
+ Removed JSON + Collapsed Steps + Simplified plan text
…-2' into jetty-12.0.x-object-identity-ee8-and-ee9
…-2' into jetty-12.0.x-object-identity-ee8-and-ee9
…oss-context-testing-2
…-2' into jetty-12.0.x-object-identity-ee8-and-ee9
@gregw can I get a re-review? The jenkins failure is nothing to do with this PR, its a HTTP2 test failure. |
…object-identity-ee8-and-ee9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI looks like a flake
Fix to maintain object wrapper identity during cross context dispatch, only for ee8 & 9.