Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #11925 - Fix Etag NPE when using URLResource and improve Base Resource is alias warning #11930

Merged
merged 10 commits into from
Jun 25, 2024

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jun 19, 2024

  • Fix the NPE seen in Etag handling while using URLResource.
  • Improve error message "Base Resource should not be an alias" with more context.

Fixes: #11925

@@ -74,6 +74,8 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<!-- Reuse Forks causes test failures -->
<reuseForks>false</reuseForks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the tests that are failing without this? You should probably open some issue about them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, opened issue #11957

@joakime joakime merged commit f78f442 into jetty-12.0.x Jun 25, 2024
10 checks passed
@joakime joakime deleted the fix/12.0.x/npe-from-non-existant-etag branch June 25, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

java.lang.NullPointerException: Cannot invoke "String.startsWith(String)" because "etag" is null
2 participants