Issue #12000 Replace URI.create with ResourceFactory in jetty maven plugin #12003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbartel
deleted the
jetty-12.0.x-12000-fix-combinedresources-maven-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12000
The jetty maven plugin
MavenWebAppContextclass was callingURI.createto change user-entered locations into URIs and then creating a combined resource from them. Changed to usingResourceFactory.newResource(String)method, and thenResourceFactory.combine(List<Resource>)method instead.Also updated one of the jetty maven plugin it tests to use a directory that contains space in it's name as one of the alternate resource bases to exercise this fix.