Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Regression on ee9 / ee8 MultiPart parsing #12031

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Fix Regression on ee9 / ee8 MultiPart parsing #12031

merged 5 commits into from
Jul 16, 2024

Commits on Jul 11, 2024

  1. Regression on ee9 / ee8 MultiPart parsing behavior with empty request… 

    … body
    @joakime
    joakime committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fd78e2b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. More testing of regression. 

    + More multipart parsing errors return 400, not 500 now.
    @joakime
    joakime committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7e58921 View commit details
    Browse the repository at this point in the history

  2. Fix test assumptions

    @joakime
    joakime committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0b72d81 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Reworked so that Request handles Bad Message from Multipart Parsing. 

     * Request.getParts() catches IOExceptions from multiParts.getParts() and wraps them in a BadMessageException to ensure that a 400 Bad Request response shows up.
    @joakime
    joakime committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7085a50 View commit details
    Browse the repository at this point in the history

  2. Fix checkstyle

    @joakime
    joakime committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    68bc1fb View commit details
    Browse the repository at this point in the history