Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment/jetty 12.1.x/iterating callback complete #12055

Closed
wants to merge 5 commits into from
Closed

Experiment/jetty 12.1.x/iterating callback complete #12055

wants to merge 5 commits into from

Commits on Jul 15, 2024

  1. Experiment with IteratingCallback 

    The previous semantic of `onCompleteFailure` has been renamed to `onFailure(Throwable)`, which is called immediately (but serialized) on either an abort or a failure.   A new `onCompleteFailure(Throwable)` method has been added that is called only after a `failed(throwable)` or a `abort(Throwable)` followed by `succeeded()` or `failed(Throwable)``

No usage has yet been made of the new `onCompleteFailure`, but the ICB implementation has been completely replaced by the one developed in #11876
    @gregw
    gregw committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6858307 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Experiment with IteratingCallback 

    The previous semantic of `onCompleteFailure` has been renamed to `onFailure(Throwable)`, which is called immediately (but serialized) on either an abort or a failure.   A new `onCompleteFailure(Throwable)` method has been added that is called only after a `failed(throwable)` or a `abort(Throwable)` followed by `succeeded()` or `failed(Throwable)``

No usage has yet been made of the new `onCompleteFailure`, but the ICB implementation has been completely replaced by the one developed in #11876
    @gregw
    gregw committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2b60a6d View commit details
    Browse the repository at this point in the history

  2. Experiment with IteratingCallback 

    The previous semantic of `onCompleteFailure` has been renamed to `onFailure(Throwable)`, which is called immediately (but serialized) on either an abort or a failure.   A new `onCompleteFailure(Throwable)` method has been added that is called only after a `failed(throwable)` or a `abort(Throwable)` followed by `succeeded()` or `failed(Throwable)``

No usage has yet been made of the new `onCompleteFailure`, but the ICB implementation has been completely replaced by the one developed in #11876
    @gregw
    gregw committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c2742cc View commit details
    Browse the repository at this point in the history

  3. Reduce capture of this:: on hot path

    @gregw
    gregw committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4c28464 View commit details
    Browse the repository at this point in the history

  4. revert the renaming of onCompleteFailure to onFailure

    @gregw
    gregw committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7f373a4 View commit details
    Browse the repository at this point in the history