Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6514 - How to warm up SslConnection. #12151

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Fixes #6514 - How to warm up SslConnection. #12151

merged 4 commits into from
Aug 20, 2024

Commits on Aug 8, 2024

  1. Fixes #6514 - How to warm up SslConnection. 

    Implemented "priming" of HTTP/1.1 connections using ConnectionPool.preCreateConnections(int) and HttpClientTransportOverHTTP.setInitializeConnections(true).

This sends `OPTIONS * HTTP/1.1` to the server.

I tried to implement this feature by forcing a write of 0 bytes from the layer above `SslConnection`, but it did not work when using TLS because in both WriteFlusher and SslConnection the fact that there are 0 bytes left to write is treated specially.

Other HTTP versions have no problems because they must initialize the connection by e.g. sending a SETTINGS frame, so they would also initialize TLS.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7c1ecea View commit details
    Browse the repository at this point in the history

  2. Forgot license header. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    43cc9f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Added javadocs as suggested from review. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    014c05f View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Added javadocs as per review suggestion. 

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8737ce4 View commit details
    Browse the repository at this point in the history