Fixes #12154 - Limit concurrent virtual threads. #12155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated VirtualThreadPool to limit the number of concurrent virtual threads using a Semaphore. Updated modules and documentation. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@sbordet can we make this do if anybody configures the limit to less than 10000 it does "warning: just use normal threads. The emperor is indeed naked!" |
|
@gregw sure, but I think you meant "less than a million" 🤣 |
gregw
requested changes
Aug 18, 2024
| #jetty.threadPool.namePrefix=vtp<hashCode> | ||
|
|
||
| ## Maximum number of concurrent virtual threads. |
There was a problem hiding this comment.
I don't think "concurrent" is correct or necessary here. It makes it sound like there could be a lot more virtual threads, but only a limited number concurrently executing (which is a factor of cores and/or native threads).
Suggested change
| ## Maximum number of concurrent virtual threads. | |
| ## Maximum number of live virtual threads. |
jetty-core/jetty-server/src/main/config/modules/threadpool-all-virtual.mod
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
previously approved these changes
Aug 20, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
deleted the
fix/jetty-12.0.x/12154/add-semaphore-virtual-threads
branch
sbordet
added a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated VirtualThreadPool to limit the number of concurrent virtual threads using a Semaphore.
Updated modules and documentation.