Fixes #12063 - Introduce Jetty module for HTTP/2 client dependencies. #12170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made client.mod download dependencies via a [files] section. Introduced http2-client.mod and http2-client-transport.mod. These modules download dependencies via a [files] section. They can be used to have the server provide the dependencies in case of a web application proxies request using HTTP/2. Fixed ContentProvider to set the context ClassLoader before reading the Jetty XML context file, which may reference classes from the web application. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
requested changes
Aug 18, 2024
jetty-core/jetty-deploy/src/main/java/org/eclipse/jetty/deploy/providers/ContextProvider.java
Show resolved
Hide resolved
jetty-home/pom.xml
Outdated
| @@ -337,7 +341,7 @@ | |||
| <configuration> | |||
| <includeGroupIds>org.eclipse.jetty</includeGroupIds> | |||
| <excludeGroupIds>org.eclipse.jetty.orbit,org.eclipse.jetty.http2,org.eclipse.jetty.http3,org.eclipse.jetty.quic,org.eclipse.jetty.websocket,org.eclipse.jetty.ee8.websocket,org.eclipse.jetty.ee9.websocket,org.eclipse.jetty.ee10.websocket,org.eclipse.jetty.fcgi,org.eclipse.jetty.toolchain,org.apache.taglibs</excludeGroupIds> | |||
| <excludeArtifactIds>jetty-ee8-apache-jsp,jetty-ee9-apache-jsp,jetty-ee10-apache-jsp,jetty-ee8-glassfish-jstl,jetty-ee9-glassfish-jstl,jetty-ee10-glassfish-jstl,jetty-start,jetty-slf4j-impl,javadoc</excludeArtifactIds> | |||
| <excludeArtifactIds>jetty-alpn-client,jetty-alpn-java-client,jetty-client,jetty-ee8-apache-jsp,jetty-ee9-apache-jsp,jetty-ee10-apache-jsp,jetty-ee8-glassfish-jstl,jetty-ee9-glassfish-jstl,jetty-ee10-glassfish-jstl,jetty-start,jetty-slf4j-impl,javadoc</excludeArtifactIds> | |||
There was a problem hiding this comment.
Are you sure you want to exclude jetty-client, it is needed for things like jakarta-websocket-server module, so will save downloading it.
And if they are currently using a 12.0.x release with this then the jar disappears from jetty-home in the next point release, then they will have to re-run the --add-modules command to download it.
There was a problem hiding this comment.
Ah yes, the dreaded "the server depends on the client" WebSocket thing 🙄
gregw
previously approved these changes
Aug 19, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
jetty-core/jetty-http2/jetty-http2-client/src/main/config/modules/http2-client.mod
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made client.mod download dependencies via a [files] section.
Introduced http2-client.mod and http2-client-transport.mod.
These modules download dependencies via a [files] section.
They can be used to have the server provide the dependencies in case of a web application proxies request using HTTP/2.
Fixed ContentProvider to set the context ClassLoader before reading the Jetty XML context file, which may reference classes from the web application.