Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change urls https://eclipse.dev to https://jetty.org #12172

Merged
merged 5 commits into from
Aug 21, 2024
Merged

change urls https://eclipse.dev to https://jetty.org #12172

merged 5 commits into from
Aug 21, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 19, 2024

Signed-off-by: Olivier Lamy olamy@apache.org

joakime
joakime requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some URLs to fix.

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/issue-template.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release-template.md Outdated Show resolved Hide resolved
jetty-ee10/jetty-ee10-demos/jetty-ee10-demo-proxy-webapp/src/main/webapp/WEB-INF/web.xml Outdated Show resolved Hide resolved
jetty-ee9/jetty-ee9-demos/jetty-ee9-demo-proxy-webapp/src/main/webapp/WEB-INF/web.xml Outdated Show resolved Hide resolved
@olamy olamy requested a review from joakime August 20, 2024 01:59
@joakime
Copy link
Contributor

joakime commented Aug 20, 2024

The changes you have here have broken the org.eclipse.jetty.tests.distribution.DistributionTests.testWebAppWithProxyAndJPMS tests.

joakime
joakime requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the new test failures (not flaky) of org.eclipse.jetty.tests.distribution.DistributionTests.testWebAppWithProxyAndJPMS

@olamy
change urls https://eclipse.dev to https://jetty.org
0588a0d 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix wrong url
b997ee7 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix security url
69931ad 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix download link
69285c1 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Fix distribution test
7ed5807 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the jetty-12.0.x-cleanup-eclipse-urls branch from 8c99fa8 to 7ed5807 Compare August 20, 2024 22:48
@olamy
Copy link
Member Author

olamy commented Aug 21, 2024

fixed

@olamy olamy requested a review from joakime August 21, 2024 00:02
@olamy olamy merged commit 2ca9be9 into jetty-12.0.x Aug 21, 2024
9 checks passed
@olamy olamy deleted the jetty-12.0.x-cleanup-eclipse-urls branch August 21, 2024 05:18
@sbordet sbordet mentioned this pull request Aug 21, 2024
Closed
sbordet pushed a commit that referenced this pull request Aug 23, 2024
@olamy @sbordet
change urls https://eclipse.dev to https://jetty.org (#12172)
ba4cc39 
* change urls https://eclipse.dev to  https://jetty.org

---------

Signed-off-by: Olivier Lamy <olamy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamy @joakime