Fix potential NPE from VirtualThreadPool #12198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure from
testThreadPool – org.eclipse.jetty.util.thread.QueuedThreadPoolTest
https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-12181/7/tests
Looks like a race condition where
doStop()
is called while an execute has been called. This PR stopssemaphore
from being null between theif (semaphore != null)
check and thesemaphore.acquire()
.