Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12255 Dump CookieConfig #12257

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

janbartel
Copy link
Contributor

Closes #12255

Dump CookieConfig.

@janbartel janbartel requested a review from joakime September 11, 2024 07:01
@janbartel janbartel self-assigned this Sep 11, 2024
@joakime
Copy link
Contributor

joakime commented Sep 11, 2024

This works for the Server dump.

How about doing some extra work for the JMX level?
Since these objects derive from ContainerLifeCycle, they are already a @ManagedObject.
Lets cleanup the @ManagedObject description, and specify a few getter method for @ManagedAttribute too?

@janbartel
Copy link
Contributor Author

@joakime the CookieConfig classes aren't and haven't ever been visible in JMX. However, in past releases there have been @ManagedAttribute annotations on the SessionHandler methods that are equivalent to calling the CookieConfig methods. I can add those if you like.

@joakime
Copy link
Contributor

joakime commented Sep 12, 2024

@joakime the CookieConfig classes aren't and haven't ever been visible in JMX. However, in past releases there have been @ManagedAttribute annotations on the SessionHandler methods that are equivalent to calling the CookieConfig methods. I can add those if you like.

See JMX:

Screenshot from 2024-09-10 08-54-06

Just as a note, ANY class derived from ContainerLifeCycle will show up on JMX.

@janbartel
Copy link
Contributor Author

@joakime I'm attaching a screen cap of jmx mbeans with jetty-11. As you can see only the getters/setters on the SessionHandler are exposed. Note that the CookieConfig classes are not ContainerLifeCycles in any version of jetty, it's only the SessionHandler that is.
Screenshot from 2024-09-13 08-30-54

joakime
joakime previously approved these changes Sep 12, 2024
@joakime joakime merged commit 41333a7 into jetty-12.0.x Sep 18, 2024
12 checks passed
@joakime joakime deleted the jetty-12.0.x-12255-dump-cookieconfig branch September 18, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Environment CookieConfig details not visible in Server Dump or JMX
2 participants