-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #9980 - add additional codes for CustomRequestLog #12322
Issue #9980 - add additional codes for CustomRequestLog #12322
Conversation
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Can request scheme be Or perhaps enhance the param portion of like ...
|
I agree with @joakime as long as we have also |
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
I have added the changes requested. Note that there are now some duplicate codes:
|
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor nits on the javadocs.
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/CustomRequestLog.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/CustomRequestLog.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/CustomRequestLogTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Adds the following options to the CustomRequestLog
Let me know if you can think of better codes for these.
closes #9980