Issue #3011 - Moving HttpCompliance to HttpConfiguration #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
force-pushed
the
jetty-10.x-issue-3011-move-httpcompliance-to-config
branch
from
30853b9
to
4679565
Compare
sbordet
requested changes
Oct 22, 2018
| @@ -63,26 +56,18 @@ public HttpConfiguration getHttpConfiguration() | |||
|
|
|||
| public HttpCompliance getHttpCompliance() | |||
| { | |||
| return _httpCompliance; | |||
| return _config.getHttpCompliance(); | |||
There was a problem hiding this comment.
Remove this method now that HttpCompliance is not a field of this class.
+ Can get HttpCompliance from HttpConfiguration now + Signature change to HttpConnection to avoid duplicate arguments on constructor. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
approved these changes
Oct 22, 2018
joakime
deleted the
jetty-10.x-issue-3011-move-httpcompliance-to-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com