Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out WebSocket core features into new websocket-core components #3055

Merged
merged 357 commits into from
Nov 2, 2018
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Feb 8, 2018

  1. Adding more todos

    joakime committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    2fa947b View commit details
    Browse the repository at this point in the history
  2. More websocket test updates

    joakime committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    a3df307 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    60e6253 View commit details
    Browse the repository at this point in the history
  4. AcceptHash improved testing

    joakime committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    27cdc19 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    081737e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee3a665 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8968d97 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3d6d6fa View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Using proper sub-protocol

    joakime committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    f2a47be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f84b98e View commit details
    Browse the repository at this point in the history
  3. Minor test updates

    joakime committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    19daa65 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    316a6f8 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2018

  1. More websocket test updates

    joakime committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    bc995bb View commit details
    Browse the repository at this point in the history
  2. Update for null/empty payload

    joakime committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    8646b3a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ddac20 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Configuration menu
    Copy the full SHA
    bb4225b View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Configuration menu
    Copy the full SHA
    384a919 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    430c4a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aee1100 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    acca982 View commit details
    Browse the repository at this point in the history
  5. More websocket test updates

    joakime committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    69dd653 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2018

  1. Merge remote-tracking branch 'origin/jetty-10.0.x' into jetty-10.0.x-…

    …websocket
    
    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    
    # Conflicts:
    #	Jenkinsfile
    #	jetty-util/src/main/java/org/eclipse/jetty/util/BufferUtil.java
    #	jetty-websocket/javax-websocket-client-impl/pom.xml
    #	jetty-websocket/javax-websocket-server-impl/pom.xml
    #	jetty-websocket/websocket-api/pom.xml
    #	jetty-websocket/websocket-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java
    #	jetty-websocket/websocket-common/src/main/java/org/eclipse/jetty/websocket/common/WebSocketRemoteEndpoint.java
    #	jetty-websocket/websocket-common/src/main/java/org/eclipse/jetty/websocket/common/WebSocketSession.java
    #	jetty-websocket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/extensions/AbstractExtension.java
    #	jetty-websocket/websocket-server/src/main/java/org/eclipse/jetty/websocket/server/NativeWebSocketConfiguration.java
    #	jetty-websocket/websocket-server/src/main/java/org/eclipse/jetty/websocket/server/WebSocketServerFactory.java
    #	jetty-websocket/websocket-tests/src/main/java/org/eclipse/jetty/websocket/tests/LocalWebSocketConnection.java
    joakime committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    3da45ce View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. Merge remote-tracking branch 'origin/jetty-10.0.x' into jetty-10.0.x-…

    …websocket
    
    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    
    # Conflicts:
    #	Jenkinsfile
    #	jetty-websocket/javax-websocket-client-impl/src/main/java/org/eclipse/jetty/websocket/jsr356/ClientContainer.java
    #	jetty-websocket/javax-websocket-server-impl/pom.xml
    #	jetty-websocket/javax-websocket-server-impl/src/main/java/org/eclipse/jetty/websocket/jsr356/server/AnnotatedServerEndpointConfig.java
    #	jetty-websocket/websocket-api/pom.xml
    #	jetty-websocket/websocket-common/src/main/java/org/eclipse/jetty/websocket/common/extensions/WebSocketExtensionFactory.java
    #	jetty-websocket/websocket-server/pom.xml
    #	jetty-websocket/websocket-server/src/main/java/org/eclipse/jetty/websocket/server/NativeWebSocketConfiguration.java
    #	jetty-websocket/websocket-server/src/main/java/org/eclipse/jetty/websocket/server/WebSocketServerFactory.java
    #	jetty-websocket/websocket-servlet/src/main/java/org/eclipse/jetty/websocket/servlet/ServletUpgradeRequest.java
    joakime committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    4835707 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Fixing compilation

    joakime committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    e83fe97 View commit details
    Browse the repository at this point in the history
  2. WebSocket test fixes

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    90ba20d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. Fixing ContinuationTest assertions

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    e16d35c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. fixed package

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed May 1, 2018
    Configuration menu
    Copy the full SHA
    0aa9f68 View commit details
    Browse the repository at this point in the history
  2. Added some better examples of QuotedCSV

    I think this test is trying to use QuotedCSV in the wrong way, as it often is offering values when it should be testing parameters.
    I have added some examples to show that QuotedCSV is capable of handling the quotes, spaces and embedded commas of the tests, but only
    for parameters and not for values.   The question is, is this sufficient for websocket?
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed May 1, 2018
    1 Configuration menu
    Copy the full SHA
    48bb745 View commit details
    Browse the repository at this point in the history
  3. Improve close handling

    The handling of a Close Frame may close the endpoint, so parsing should not continue
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed May 1, 2018
    Configuration menu
    Copy the full SHA
    1501e81 View commit details
    Browse the repository at this point in the history
  4. moved old AbstractFrameHandler to test

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed May 1, 2018
    Configuration menu
    Copy the full SHA
    487855d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. implement ingoing and outgoing frame sequence checking

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed May 2, 2018
    Configuration menu
    Copy the full SHA
    15766be View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2018

  1. Configuration menu
    Copy the full SHA
    a563e20 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'jetty-10.0.x-websocket' of github.com:eclipse/jetty.pro…

    …ject into jetty-10.0.x-websocket
    joakime committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    9b5c57a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d803d69 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. Configuration menu
    Copy the full SHA
    b8fffb9 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2018

  1. JSR356 @PathParam testing

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    8cec071 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a57f2de View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2018

  1. Configuration menu
    Copy the full SHA
    1996e31 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2018

  1. WebSocket Idle Timeout from FrameHandler specific policy

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    0ebcdeb View commit details
    Browse the repository at this point in the history
  2. WebSocket/JSR Pong support

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    90ca423 View commit details
    Browse the repository at this point in the history
  3. WebSocket/JSR Correcting MessageHandler.Whole<PongMessage> handling

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    b163887 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. URL Decode UriTemplatePathSpec values

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    36cf962 View commit details
    Browse the repository at this point in the history
  2. Fixing test expectations

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    888f039 View commit details
    Browse the repository at this point in the history
  3. Fixing AbstractWholeMessageHandler buffer flip

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    e4a2628 View commit details
    Browse the repository at this point in the history
  4. More websocket test fixes

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    450e1e3 View commit details
    Browse the repository at this point in the history
  5. Updated ALPN version for JDK 8u181.

    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    sbordet authored and joakime committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    938da99 View commit details
    Browse the repository at this point in the history
  6. Removing QuotedUtil from WebSocket-core

    + Moved to QuotedCSV for most usages
    + Introduced HeaderUtil to satisfy remaining use cases
    
    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    98a64f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. Review of HttpClient names and Thread names.

    + Javax WebSocket Server = "Javax-WebSocketServer@####"
    + Javax WebSocket Client = "Javax-WebSocketClient@####"
    
    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    afcb8ac View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. added OpCodeTest.java

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    91b1bf2 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Minor Frame cleanup

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    c813938 View commit details
    Browse the repository at this point in the history
  2. MessageOS cleanup

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    d15191c View commit details
    Browse the repository at this point in the history
  3. Made the OpCode of WebSocket Frame immutable.

    Frames can no longer be set as a continuation and should now be copied using the ContinuationFrame constructor
    DataFrames can no longer be created without one of the subclasses as the public constructor was removed in favour of newDataFrame method
    lachlan-roberts committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    f96d58d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2018

  1. Chat test

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    5769b1c View commit details
    Browse the repository at this point in the history
  2. Work on Chat Test

    Moved implementation of assertValid to WebSocketFrame
    Removed getFinRsvOp
    lachlan-roberts committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    dcf289f View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Merge branch 'jetty-10.0.x' into jetty-10.0.x-websocket

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    153228d View commit details
    Browse the repository at this point in the history
  2. removed constructors for DataFrame using a basedOn Frame

    instead use constructors with opCode, payload and fin bit
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    cdf20c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2018

  1. refactor of WebSocket Frames WIP

    Signed-off-by: lachan-roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    e973a30 View commit details
    Browse the repository at this point in the history
  2. WIP: resolved failing tests

    Signed-off-by: lachan-roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    fc7318a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2018

  1. CloseStatus rework, now use CloseStatus.toFrame to create Close Frames

    new DelegateFrame class which ReadOnlyFrame extends
    trim utf8 byte array in CloseStatus to utf8 character boundaries only
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    e3b969d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2018

  1. working on test to test socket io erros in websocket-core

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    ee4caff View commit details
    Browse the repository at this point in the history
  2. renaming for clarity

    Gave up on maintaining old names, as this is a different package anyway so some adaption will be needed regardless.
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    412691f View commit details
    Browse the repository at this point in the history
  3. Moved AbstractFrameHandlers to common

    Only have a AbstractTestFrameHandler in core
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    0c3cbf0 View commit details
    Browse the repository at this point in the history
  4. Close uses CloseStatus

    Reduced the parsing and generation of CloseStatus when closing
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    56330fc View commit details
    Browse the repository at this point in the history
  5. merge

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    143810f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. work on WebSocketTest

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    3f1e8d2 View commit details
    Browse the repository at this point in the history
  2. cleanup log

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    ab134a4 View commit details
    Browse the repository at this point in the history
  3. wip

    Signed-off-by: lachan-roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    dbdba4b View commit details
    Browse the repository at this point in the history
  4. files missing comment header

    jetty-jmh was using 9.4.12-SNAPSHOT now using 10.0.0-SNAPSHOT
    
    Signed-off-by: lachan-roberts <lachlan@webtide.com>
    lachlan-roberts committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    3ef053e View commit details
    Browse the repository at this point in the history
  5. Merge branch 'jetty-10.0.x-websocket-FrameRefactor' of github.com:web…

    …tide/jetty.collaboration into jetty-10.0.x-websocket-FrameRefactor
    gregw committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    c0e34a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2018

  1. thread names

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    0eab8cf View commit details
    Browse the repository at this point in the history
  2. remove sequence check from parser

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    8a68a50 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. minor cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    5ab2996 View commit details
    Browse the repository at this point in the history
  2. Call frameHandler externally to parser

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    cf14659 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. OpCode.check now throws ProtocolException instead of returning boolean

    changed ProtocolException messages in OpCode.check
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    bc766ff View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. removed Frame.Type and use OpCode instead

    separated out FrameValidation for parser into method in WebSocketChannel
    
    Signed-off-by: lachan-roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    6b3d72c View commit details
    Browse the repository at this point in the history
  2. moved remaining frame validation checks into WebSocketChannel

    Signed-off-by: lachan-roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    ab90164 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. referenced counted buffer

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    9b22cfc View commit details
    Browse the repository at this point in the history
  2. cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    d61833c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. wip on demand side

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    e5f581e View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2018

  1. First attempt at demandable

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    72ed1cb View commit details
    Browse the repository at this point in the history
  2. demand control

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    d259c2c View commit details
    Browse the repository at this point in the history
  3. clean up reference counting

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    8bdc85c View commit details
    Browse the repository at this point in the history
  4. clean ups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    c520ce9 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. WebSocketServerTest

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    edad37d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2018

  1. wip

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    68605e1 View commit details
    Browse the repository at this point in the history
  2. fixed auto fragmentation

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    c918bdb View commit details
    Browse the repository at this point in the history
  3. simple demand test

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    abbf2a9 View commit details
    Browse the repository at this point in the history
  4. test demand and retain

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    57df935 View commit details
    Browse the repository at this point in the history
  5. Added validation back into the Parser

    split up validation in WSChannel into methods for incoming and outgoing
    fixed various tests in websocket-core
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    2b31bc4 View commit details
    Browse the repository at this point in the history
  6. more tests

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    76389fb View commit details
    Browse the repository at this point in the history
  7. Merge branch 'jetty-10.0.x-websocket-frameValidation' of github.com:w…

    …ebtide/jetty.collaboration into jetty-10.0.x-websocket-frameValidation
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    a075331 View commit details
    Browse the repository at this point in the history
  8. fixed remaining tests failing due to the changes to frame validation

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    42d8bb2 View commit details
    Browse the repository at this point in the history
  9. cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    d94ff32 View commit details
    Browse the repository at this point in the history
  10. more autobahn refixes

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    7884af1 View commit details
    Browse the repository at this point in the history
  11. adjust mask for auto fragments

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    8cb1076 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. clear mask

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f53a5e3 View commit details
    Browse the repository at this point in the history
  2. fully close on unrecoverable error and not wait for close response

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    dd33418 View commit details
    Browse the repository at this point in the history
  3. Removed the CoreFuzzer and ContinuationTest

    These tests are now covered elsewhere.
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f5327e9 View commit details
    Browse the repository at this point in the history
  4. remove declared exception onClosed

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    226f654 View commit details
    Browse the repository at this point in the history
  5. Test delay close

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    ca05e66 View commit details
    Browse the repository at this point in the history
  6. Test handler close

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1a3a0fa View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. fixed test dependency

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    34bdaad View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. moved the frame sequence check from OutgoingState from after the Exte…

    …nsionStack to channel.sendFrame
    
    changed error handling to fail the callback of invalid/outOfSequence frames
    added WebSocket Close tests revealing some problems with demand in state ICLOSE
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    358685a View commit details
    Browse the repository at this point in the history
  2. cleanup

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    377563b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. timing issues with WebSocketCloseTest

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    9caca93 View commit details
    Browse the repository at this point in the history
  2. test cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    a5e30e6 View commit details
    Browse the repository at this point in the history
  3. Cancel demand on close

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    06ed7f1 View commit details
    Browse the repository at this point in the history
  4. removed frame validation from generator

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    51c5df8 View commit details
    Browse the repository at this point in the history
  5. finished close testing

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    327f410 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'jetty-10.0.x-websocket-frameValidation' of github.com:w…

    …ebtide/jetty.collaboration into jetty-10.0.x-websocket-frameValidation
    gregw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    d8c73f3 View commit details
    Browse the repository at this point in the history
  7. Issue #2901 - Moving Http Upgrader to Http Conversation

    + Solves for Authentication and Redirect
    
    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime authored and lachlan-roberts committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    ebf9dbe View commit details
    Browse the repository at this point in the history
  8. changes from #2902 to jetty-10.0.x

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    63d17e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Validation Extension

    introduced a ValidationExtension to do frame validation in the ExtensionStack
    added the WebSocketChannel to ExtensionStack.connect to set it on the Extensions
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    34326ca View commit details
    Browse the repository at this point in the history
  2. added parameters for ValidationExtension to choose what to validate

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    6f1dde1 View commit details
    Browse the repository at this point in the history
  3. ValidationExtension Cleanup

    ValidationExtension now uses the Validation methods from its WebSocketChannel
    simplified the parameter passing to the ValidationExtension
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    02f5dfd View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. core cleanup

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    9fa43fd View commit details
    Browse the repository at this point in the history
  2. Fixed intermittent test failures

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    fa73fa2 View commit details
    Browse the repository at this point in the history
  3. clean up duplicates and imports

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    680ee9d View commit details
    Browse the repository at this point in the history
  4. simplified package structure

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    df84930 View commit details
    Browse the repository at this point in the history
  5. many cleanups, simplifications and duplication removal

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    61f7803 View commit details
    Browse the repository at this point in the history
  6. cleanup

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    21fefa3 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2018

  1. added utf8 validation for text frames into ValidationExtension

    added tests for utf8 validation
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    f064586 View commit details
    Browse the repository at this point in the history
  2. create ValidationExtensionTest

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    2b818f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. cleanup

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    0d7063a View commit details
    Browse the repository at this point in the history
  2. Merge branch 'jetty-10.0.x' into jetty-10.0.x-websocket

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    da95c7c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2018

  1. merge with jetty-10

    update websocket to junit5
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    0326415 View commit details
    Browse the repository at this point in the history
  2. fix to autobahn client report directory

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    86609b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2018

  1. Fixes and cleanup

    Fixed initial buffer too large for websocket buffer
    less verbose debug
    better debug
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    07e4ffd View commit details
    Browse the repository at this point in the history
  2. Removed behavior from policy

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    9adc82a View commit details
    Browse the repository at this point in the history
  3. cleanup after merge from hell

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    3bcefdc View commit details
    Browse the repository at this point in the history
  4. bug fixes and cleanups

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    0a0053a View commit details
    Browse the repository at this point in the history
  5. refactor packages with JPMS in mind

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    7c7cc73 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. unit test for TextMessageHandler

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    4df4460 View commit details
    Browse the repository at this point in the history
  2. cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    63235be View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2018

  1. more cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    481bfef View commit details
    Browse the repository at this point in the history
  2. provided client/server dependencies

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    be8a43c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. fixed bad refactor

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    6fbe6bd View commit details
    Browse the repository at this point in the history
  2. use lambdas for TextMessageHandler

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    9b14d3f View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. cleanup

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    cb02030 View commit details
    Browse the repository at this point in the history
  2. cleanup

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    4239411 View commit details
    Browse the repository at this point in the history
  3. cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    4d0afe1 View commit details
    Browse the repository at this point in the history
  4. cleanup of websocket-common framehandlers

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    a5b6d5a View commit details
    Browse the repository at this point in the history
  5. reverting to jetty websocket api from 9.4

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    f19a9b0 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'jetty-10.0.x-websocket' of github.com:webtide/jetty.col…

    …laboration into jetty-10.0.x-websocket
    gregw committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    147d568 View commit details
    Browse the repository at this point in the history
  7. better chat

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    14627ee View commit details
    Browse the repository at this point in the history
  8. renamed websocket common to util

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    4f0d35c View commit details
    Browse the repository at this point in the history
  9. save wip on jetty-websocket-tests

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    90a442d View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. giving up on jetty-websocket-tests as mostly duplicated tests

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    39b5e75 View commit details
    Browse the repository at this point in the history
  2. renamed websocket-util back to websocket-common

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    806a9d5 View commit details
    Browse the repository at this point in the history
  3. moved InvalidWebSocketException to javax common

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    e7e4724 View commit details
    Browse the repository at this point in the history
  4. reworked TextMessageHandler to MessageHandler

    now handles binary messages as well
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    80df5ad View commit details
    Browse the repository at this point in the history
  5. implemented getByteBufferPool in remaining DummyChannel classes

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    8f0ed57 View commit details
    Browse the repository at this point in the history
  6. Moved the abstract Frame and Message handlers out of websocket-common

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    9d1a0ee View commit details
    Browse the repository at this point in the history
  7. replaced usages of AbstractWholeMessageHandler with CoreMessageHandler

    renamed MessageHandler to CoreMessageHandler
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    6dbd63f View commit details
    Browse the repository at this point in the history
  8. removed AbstractFrameTypeHandler

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    75b840d View commit details
    Browse the repository at this point in the history
  9. cleanup

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    58d48ab View commit details
    Browse the repository at this point in the history
  10. jetty-websocket-common passing tests without websocket-common dependency

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    2a7d515 View commit details
    Browse the repository at this point in the history
  11. fixed compile errors

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    18dfccf View commit details
    Browse the repository at this point in the history
  12. renamed MessageHandler

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    0bcd037 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2018

  1. Removing reference to websocket-server (no longer exists)

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    138550f View commit details
    Browse the repository at this point in the history
  2. Removing, Extensions now exist in websocket-core

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    781a60b View commit details
    Browse the repository at this point in the history
  3. Do not append an empty ByteBuffer

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    fc983ac View commit details
    Browse the repository at this point in the history
  4. NPE Fix for empty/unused UTF-8 String Builder

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    fa26d3a View commit details
    Browse the repository at this point in the history
  5. NPE Fix for SendPartialBinaryFrameHandler test

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    dad931a View commit details
    Browse the repository at this point in the history
  6. Punching holes in WebAppContext needed for JSR356 use

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    1dbe963 View commit details
    Browse the repository at this point in the history
  7. Updating "9.x.x" to "10.x.x"

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    1b33dd1 View commit details
    Browse the repository at this point in the history
  8. Removing Bad URI test case that is ignored

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    a82b39b View commit details
    Browse the repository at this point in the history
  9. Fixing test expectation now that we moved to QuotedCSV

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    82d9b0b View commit details
    Browse the repository at this point in the history
  10. Adding TODO about onOpen failure requiring onError + onClose.

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    0636667 View commit details
    Browse the repository at this point in the history
  11. Throwing JSR356 DeploymentException on addEndpoint() failure

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    2327a51 View commit details
    Browse the repository at this point in the history
  12. Test cleanup (for better error messages)

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    a847960 View commit details
    Browse the repository at this point in the history
  13. Adding some comments to explain wrapNonVoidReturnType()

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    98f0aa0 View commit details
    Browse the repository at this point in the history
  14. cleanup methodHandle return type filtering

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    725a0dc View commit details
    Browse the repository at this point in the history
  15. test fixes

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    37c7eb1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. Fix change return type to Void

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    df272bd View commit details
    Browse the repository at this point in the history
  2. Fixed test by wiring up MessageHandler

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    7003482 View commit details
    Browse the repository at this point in the history
  3. test cleanups

    removed changeReturnType for MethodHandle as filterReturnValue already changes to return type of the filter
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    f8e2ea3 View commit details
    Browse the repository at this point in the history
  4. fixed MessageReceivingTest.testPartialBinaryFrameHandler

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    9789568 View commit details
    Browse the repository at this point in the history
  5. Core BatchMode replaced by boolean

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    d2f111c View commit details
    Browse the repository at this point in the history
  6. Merge branch 'jetty-10.0.x-websocket' of github.com:webtide/jetty.col…

    …laboration into jetty-10.0.x-websocket
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    0835051 View commit details
    Browse the repository at this point in the history
  7. fixed LargeContainerTest.testEcho by allowing the policy to be set on…

    … the WSServer as an attribute
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    dcdf636 View commit details
    Browse the repository at this point in the history
  8. acquire batchBuffer before calculating batchSpace in FrameFlusher

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    2e23374 View commit details
    Browse the repository at this point in the history
  9. Deprecated WebSocketPolicy

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    999727b View commit details
    Browse the repository at this point in the history
  10. Fixing MessageReceivingTest

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    b649dcf View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Refactoring out websocket-servlet

    + WebSocketPolicy removed from websocket-servlet
    + websocket-common is removed
    + Migrating back up to APIs
    
    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    f7bc1d4 View commit details
    Browse the repository at this point in the history
  2. WIP removing core policy

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    e73b8fb View commit details
    Browse the repository at this point in the history
  3. added missing copyright headers

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    4205f05 View commit details
    Browse the repository at this point in the history
  4. customize client session

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    f628cbd View commit details
    Browse the repository at this point in the history
  5. customize cleanup

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    a9dd7d0 View commit details
    Browse the repository at this point in the history
  6. wip

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    5da93b7 View commit details
    Browse the repository at this point in the history
  7. wip

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    7f302d3 View commit details
    Browse the repository at this point in the history
  8. Removing WebSocketPolicy usage within websocket-core

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    030c004 View commit details
    Browse the repository at this point in the history
  9. Allowing DummyCoreSession to have a Behavior

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    914b6f9 View commit details
    Browse the repository at this point in the history
  10. Removing core WebSocketPolicy.clonePolicy() - no longer used

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    4621066 View commit details
    Browse the repository at this point in the history
  11. Jetty Native WebSocket now compiles / tests

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    6083f52 View commit details
    Browse the repository at this point in the history
  12. Remember WebSocketServletFactoryImpl as Context Attribute

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    2c70a3c View commit details
    Browse the repository at this point in the history
  13. JSR356 codebase now compiles

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    d6beb4e View commit details
    Browse the repository at this point in the history
  14. updated websocket servlets

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    e58813c View commit details
    Browse the repository at this point in the history
  15. fix handling for no max message size

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    abe25cd View commit details
    Browse the repository at this point in the history
  16. Fixed LargeContainerTest.testEcho

    Changed WebSocketServletFactoryImpl.defaultAutFragment to true
    only check the incoming frame size if autoFragment is false
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    6abb4a8 View commit details
    Browse the repository at this point in the history
  17. Added WebSocketConstants to avoid duplicate default locations

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    46c2723 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. applications extensions discovered via headers

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    a3bcfa2 View commit details
    Browse the repository at this point in the history
  2. fixed ConfiguratorTest.testNoExtensionsConfigurator

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    b6d5936 View commit details
    Browse the repository at this point in the history
  3. cleaned up extension negotiation

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    b3f8f17 View commit details
    Browse the repository at this point in the history
  4. cleaned up extension negotiation

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    6fee2ff View commit details
    Browse the repository at this point in the history
  5. cleanups

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    ba22fd9 View commit details
    Browse the repository at this point in the history
  6. Convert exceptions to API versions

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    06e3d24 View commit details
    Browse the repository at this point in the history
  7. cleanup imports

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    9164e58 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2018

  1. Merge branch 'jetty-10.0.x' into jetty-10.0.x-websocket

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    112ec3c View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. Merge branch 'jetty-10.0.x' into jetty-10.0.x-websocket

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    2cee75c View commit details
    Browse the repository at this point in the history
  2. convert requestURI to a WebsocketURI in Negotiated

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    b393d68 View commit details
    Browse the repository at this point in the history
  3. fixed SessionTrackingTest

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    970abc5 View commit details
    Browse the repository at this point in the history
  4. moved session tracking management to be done by the JavaxWebSocketFra…

    …meHandler
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    dcc6a80 View commit details
    Browse the repository at this point in the history
  5. Cleanup dump for jdk11 classloaders

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    5649e78 View commit details
    Browse the repository at this point in the history
  6. fix to ConfiguratorTest

    added the EchoSocket endpoint on the ServerContainer instead of using server.registerWebSocket
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    0d94179 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3ef4f8c View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. Simplify websocket-servlet

        fixed jetty websocket chat example
        fixes for javax websocket chat example
        fixed Upgrade response header issues
        Set default configurations
        improved dump
        depends on javax server impl
        do not expose core classes
        fix javadoc
        removed FrameHandlerFactory self reference
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    1aaee00 View commit details
    Browse the repository at this point in the history
  2. Removed -impl from javax client and server

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    e9def7b View commit details
    Browse the repository at this point in the history
  3. Fixed common tests for onClosed event

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    215fcb7 View commit details
    Browse the repository at this point in the history
  4. Improve creation of JavaxWebSocketServerContainer

    Better handling of executor and httpClient as managed beans
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    e7286d6 View commit details
    Browse the repository at this point in the history
  5. Fixed MessageOutputStream using empty buffers and looping forever

    no longer enforce maxTextMessageBufferSize on partial messages
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    4b507cf View commit details
    Browse the repository at this point in the history
  6. Updates after review

    reintroduced WebSocketServletFactory
    reverted other API changes
    
    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    4e2ef7a View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. Ignored TextStreamTest tests incorrectly assuming no frame fragmentation

    When message fragmentation is implemented in PartialStringMessageSink
    then update these tests to check on the server side for no buffers
    larger than the maxTextMessageBufferSize.
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    07e9d11 View commit details
    Browse the repository at this point in the history
  2. fixed check for previous WebsocketUpgrade filter

    Disable the AltFilterTest until problems of the WebSocketUpgradeFilter
    attributes on the ServletContext are fixed.
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    7f03057 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2018

  1. Configuration menu
    Copy the full SHA
    765159a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. fixed flaky SessionTrackingTest by waiting for Sessions to open

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    3f864bc View commit details
    Browse the repository at this point in the history
  2. remove payload length check for outgoing frames

    fix bug sending frames after they have failed validation checks
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    fbc17cc View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. reverted maven coords for javax client and server

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    3eeb5f8 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'jetty-10.0.x' into jetty-10.0.x-websocket

    # Conflicts:
    #	jetty-websocket/websocket-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java
    #	jetty-websocket/websocket-common/src/main/java/org/eclipse/jetty/websocket/common/WebSocketSession.java
    #	jetty-websocket/websocket-common/src/main/java/org/eclipse/jetty/websocket/common/io/AbstractWebSocketConnection.java
    #	jetty-websocket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/AbstractExtension.java
    #	jetty-websocket/websocket-servlet/src/main/java/org/eclipse/jetty/websocket/servlet/WebSocketUpgradeFilter.java
    gregw committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    a3bf90e View commit details
    Browse the repository at this point in the history
  3. updated to latest jetty-10 dump changes

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    17ccecc View commit details
    Browse the repository at this point in the history
  4. Fix to WebSocketUpgradeFilter Attributes on the ServletContext

    Removed deprecated method
    WebSocketUpgradeFilter.configureContext(ServletContext)
    
    Changed return type of
    WebSocketUpgradeFilter.configureContext(ServletContext) to void.
    
    WebSocketUpgradeFilter.configureContext was checking the ServletContext
    for a WebSocketUpgradeFilter set as an attribute before creating a new
    one. The FilterHolder from web.xml is being set as an attribute in init
    which is called which happens after configureContext.
    So instead of checking the attribute in
    WebSocketUpgradeFilter.configureContext, we are now searching through
    the filters on the ServletHandler to see if a WebSocketUpgradeFilter
    has been registered with the CONTEXT_ATTRIBUTE_KEY.
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    769c555 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. cleanup and identifying problems with FrameHandlerMetadata

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    f9b144a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2018

  1. properly cache Metadata and copy MessageMetadata

    properly cache Metadata in the FrameHandlerFactory using the metadataMap
    copy the MessageMetadata from Metadata to prevent mutating the MethodHandle
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    296ceb3 View commit details
    Browse the repository at this point in the history
  2. added new WebSocketServerContainerExecutorTest

    removed DelayedStartClientOnServerTest which doesnt seem to be a valid
    test when executors are shared
    
    removed last check for executor==null in JavaxWebSocketServerContainerInitializer
    as the threadPool is always created in the server
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    7649ed2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    419e793 View commit details
    Browse the repository at this point in the history
  4. reformatted websocket code

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    68e0c0a View commit details
    Browse the repository at this point in the history
  5. reformat code

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    024bb61 View commit details
    Browse the repository at this point in the history
  6. Rervert unnecessary changes from 10.0.x

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    21321de View commit details
    Browse the repository at this point in the history
  7. Rervert unnecessary changes from 10.0.x

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    a085bb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2018

  1. fix build issues testing Hazelcast sessions

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    31b813e View commit details
    Browse the repository at this point in the history
  2. QuotesDecoderTest sessions not being closed

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    b4bef09 View commit details
    Browse the repository at this point in the history
  3. Fixed CookiesTest

    CookiesTest.testCookiesAreSentToClient was failing due to the
    Assertion being caught and logged by the upgrade request
    
    the response is now captured by a FuturePromise and the assertions are
    done in the main test
    
    the reason the assertion was failing was due to lowercase "set-cookie"
    instead of "Set-Cookie"
    
    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    lachlan-roberts committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    2c2ed5d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Configuration menu
    Copy the full SHA
    863673d View commit details
    Browse the repository at this point in the history
  2. fixed maven coords

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    e7df068 View commit details
    Browse the repository at this point in the history
  3. javadoc fixes

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    eb5e479 View commit details
    Browse the repository at this point in the history
  4. fixed javadoc

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    1291c6f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #3026 from webtide/jetty-10.0.x-websocket

    Jetty 10.0.x Websocket Reimport
    
    This is a reimport of the refactored websockets for jetty10 (intended to replace the current implementation from jetty9). The work is based on the jetty-10.0.x-websocket branch and refined and completed the work started there, and thus is not as large a contribution as it may appear from the change count.
    
    This contribution is entirely from myself (@lachlan-roberts who has singed the Eclipse ECA for the jetty project), and eclipse jetty committers: @gregw, @joakime and @sbordet.
    
    The protocol elements of a websocket connection have been reworked into the websocket-core module. The jetty and javax API websocket modules are now implemented using the websocket-core.
    
    This PR passes the websocket tests and autobahn testsuite, but should be considered a work in progress that needs further testing within the main jetty repository and development process.
    gregw committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    4d59e55 View commit details
    Browse the repository at this point in the history
  6. revert maven artifact names

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    70c542b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fffe0ac View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2018

  1. cleanup after review

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    gregw committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    e5539bb View commit details
    Browse the repository at this point in the history