Issue #3399 jetty.webapps.uri should be the parent of the webapp #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <janb@webtide.com>
joakime
approved these changes
Mar 11, 2019
joakime
requested changes
Mar 11, 2019
|
Well, $jetty.base/webapps isn't necessarily the directory being used. It could be the value of jetty.deploy.monitoredDir/monitoredPath. Or maybe this webapp wasn't even deployed via the deployer. So, the only information we really have is the parent dir of the webapp. I don't know what the original intention was of whoever added these properties, but at least jetty.webapps and jetty.webapps.uri should be consistent and currently they're not. |
joakime
approved these changes
Mar 13, 2019
janbartel
deleted the
jetty-10.0.x-3399-XmlConfiguration-jetty.webapps.uri
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3399
The XmlConfiguration property jetty.webapps.uri should be the uri of the parent of the webapp, but is currently the uri of the webapp itself. Fixed in jetty-10.0.x to not disturb any users in jetty-9 who are currently relying on the (incorrect) value.