WebSocketChannel bug fixes, cleanup and javadoc updates for FrameHandler #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass the cause from the AbnormalCloseStatus to closeConnection in WSChannel If onOpen throws we now throw a runtime exception in addition to failing the callback, this is to fail the CompletableFuture in the ClientUpgradeRequest. Signed-off-by: lachan-roberts <lachlan@webtide.com>
Signed-off-by: lachan-roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are the changes from #3365 which are not related to the
WebSocketProxyupdate javadoc of
FrameHandlerpass the cause from the
AbnormalCloseStatusto closeConnection inWSChannel
If
onOpen()throws we now throw a runtime exception in addition tofailing the callback, this is to fail the
CompletableFuturein theClientUpgradeRequest.new utility method in
Callbackused in WSChannel and will be used inWebSocketProxyas well