master: Support Direct Byte Buffers #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Pounds <trevor.pounds@gmail.com>
| @@ -64,6 +64,7 @@ | |||
| private boolean _delayDispatchUntilContent = true; | |||
| private boolean _persistentConnectionsEnabled = true; | |||
| private int _maxErrorDispatches = 10; | |||
| private boolean _useDirectByteBuffers = false; | |||
There was a problem hiding this comment.
I think a single boolean is too coarse a switch. Direct buffers may be beneficial for request, but not response headers/chunks of vice versa.
Perhaps an enum set to say which types of buffers are direct or not.
Also, currently ChannelEndPoint just returns true for isOptimizedForDirectBuffers, it may be best to have to influenced by this kind of configuration also.
There was a problem hiding this comment.
@gregw Really great feedback! I agree a single flag is too coarse. I'll also look into the ChannelEndPoint issue. I'll mull over some ideas and provide an update once I have something more concrete.
|
closed #349 so once we agree on a master patch, we can cherry pick back to 9.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using direct byte buffers in the internal Jetty buffer pool (see: issue #351).