Issue #3666 - error CloseFrames skip frames in the FrameFlusher queue

[lachlan-roberts]

#3666
if the FrameFlusher receives a CloseFrame with an error status it will not queue these frames behind the frames already queued in the FrameFlusher, but will fail all frames waiting to be sent and send the error CloseFrame instead

[sbordet]

@lachlan-roberts I don't think this is right.

It is perfectly acceptable for an application to send a message and then close, with the intent to deliver both the message and the close.
From what I understand of this PR you queue the message, but when you queue the close it will fail the message and this is not right.

What is the reason behind this change?

[gregw]

@sbordet read #3666
@lachlan-roberts I agree that we should abort queued frames when we are responding to an abnormal close, but should we do so if we are initiating an abnormal close??? hmmm probably yes.... if we are sending a long queue of frames and we suddenly receive a message that is too large to handle and we want to close with a 1009, then I guess we should not wait until we have flushed our queue of messages before abnormally closing.

[lachlan-roberts]

sorry had to rebase to fix failures from the WebSocketChannel rename

[lachlan-roberts]

@gregw @sbordet can I get a re-review?

[gregw]

almost....