jetty-10.0.x WebSocket core cleanup #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Jun 19, 2019
...t/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/internal/ExtensionStack.java
Show resolved
Hide resolved
...websocket/websocket-core/src/main/java/org/eclipse/jetty/websocket/core/internal/Parser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
reviewed
Jun 20, 2019
| @@ -122,8 +123,6 @@ public void negotiate(DecoratedObjectFactory objectFactory, ByteBufferPool buffe | |||
|
|
|||
| this.extensions = new ArrayList<>(); | |||
|
|
|||
| String rsvClaims[] = new String[3]; | |||
|
|
|||
| for (ExtensionConfig config : negotiatedConfigs) | |||
| { | |||
| Extension ext; | |||
There was a problem hiding this comment.
the debug logs below (a fair way) should be protected with if (LOG.isDebugEnabled ...
gregw
approved these changes
Jun 20, 2019
|
@lachlan-roberts These changes look OK, but can you check the test failures before merging. |
…etCoreCleanup Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsernow uses live configuration from the coreSession for autoFragment and maxMessage size