Checkstyle cleanup #3847
Merged
Checkstyle cleanup #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
lachlan-roberts
approved these changes
Jul 3, 2019
| @@ -497,12 +497,19 @@ public void run() | |||
| } | |||
| } | |||
|
|
|||
| // ------------------------------------------------------------ | |||
There was a problem hiding this comment.
forgot to remove this line
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java
Show resolved
Hide resolved
| @@ -1244,6 +1245,7 @@ protected PKIXBuilderParameters newPKIXBuilderParameters(KeyStore trustStore, Co | |||
|
|
|||
| return pbParams; | |||
| } | |||
| // @checkstyle-enable-check : AbbreviationAsWordInNameCheck | |||
There was a problem hiding this comment.
ditto, also strange place to put this one
There was a problem hiding this comment.
that's the way it works! turn it off before the method then back on after.... but I will try to put more locally.... it will be ugly
| "org.xml.", // javax.xml | ||
| "org.w3c." // javax.xml | ||
| ); | ||
| public static final ClassMatcher __dftSystemClasses = new ClassMatcher( |
There was a problem hiding this comment.
kinda weird that we have different styles for () vs {} bracket alignment
There was a problem hiding this comment.
I totally agree... but at this point I'm beyond the "reasoning why" and just "doing or dying"
For better or worse, that is the coding style we've gone for and let's get consistent with it for now. Once we are consistent, then making future changes is easier.
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
30+ years of computing experience have been brought to focus to implement this PR! A clean checkstyle pass through the non-test classes!
Signed-off-by: Greg Wilkins gregw@webtide.com