Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3839 - copy dependency for jetty-javax-websocket-api #3848

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Issue #3839 - copy dependency for jetty-javax-websocket-api #3848

merged 2 commits into from
Jul 10, 2019

Conversation

lachlan-roberts
Copy link
Contributor

Signed-off-by: Lachlan Roberts lachlan@webtide.com

Issue #3839

@lachlan-roberts
Issue #3839 - copy dependency for jetty-javax-websocket-api
e90b6fd 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, although I noticed #3849 when testing

sbordet
sbordet requested changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we copying also the source jars? This is for the distro, there is no need for the sources, no?

@lachlan-roberts
Copy link
Contributor Author

lachlan-roberts commented Jul 4, 2019 •
edited
Loading

@sbordet this is in the jetty-home pom, all the other examples here were copying sources as well

@lachlan-roberts lachlan-roberts merged commit 86d5ed0 into jetty-10.0.x Jul 10, 2019
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-3839-JavaxWebSocketApiJar branch July 10, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet requested changes

@gregw gregw gregw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lachlan-roberts @gregw @sbordet