Allow WebSocket extension selection to be done from UpgradeListener #4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…UpgradeListenerExtensions Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
@sbordet this change is intended to fix the issue in cometd 6 where you wanted to select extensions from the UpgradeListener. |
sbordet
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
@lachlan-roberts I have verified that the CometD 6 tests that were failing now pass cleanly with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow extensions to be set directly in the headers in the UpgradeListener.
Extensions are allowed to be set in the ClientUpgradeRequest or the UpgradeListener but not both, in which case we will abort the request.