Issue #4225 - Fix JPMS transitivity. #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
force-pushed
the
jetty-10.0.x-4225-jpms_transitivity
branch
from
04305d0
to
f561bb0
Compare
Reworked all module-info.java files to take into account JPMS transitivity. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
force-pushed
the
jetty-10.0.x-4225-jpms_transitivity
branch
from
f561bb0
to
e3bb5a7
Compare
Removed methods that were overridden to workaround jakartaee/servlet#228 in servlet-api 4.0.2, but that are now fixed in servlet-api 4.0.3. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
Could not get this to build, and when I load it up in intellij there are errors everywhere. Error from command line build:
|
Integrated Jetty WebSocket API 1.1.2. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@lachlan-roberts building with Maven would have downloaded the new artifact from the staging repository. In any case now it's in Maven Central, as the build passed fine on CI. |
…4225-jpms_transitivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4225
Reworked all module-info.java files to take into
account JPMS transitivity.
Signed-off-by: Simone Bordet simone.bordet@gmail.com