Issue #4434 Implement context default request/response encodings.

[janbartel]

Implement the new servlet spec web.xml settings of request-character-encoding/response-character-encoding and equivalent ServletContext methods.

Closes #4434

[sbordet]

@janbartel besides the "default" discussion, the build failed?

[sbordet]

@janbartel I still don't like "default" and I would like it to be removed.

Other than that, do we need changes in webdefault.xml, explicitly adding these 2 elements?

[janbartel]

I don't understand your problem with having "default" in front of the name of the default request and response character encodings? That is what they are - defaults for the context. The servlet spec api is inconsistent: sometimes it uses "default" in method names eg getDefaultSessionTrackingModes() and web.xml elements eg default-context-path, sometimes it doesn't. However, the javadoc always makes clear that these are defaults and can be overridden by other means. I don't see why if the spec is inconsistent in naming we should be too in our own impl methods.

As to your question about webdefault.xml, I don't see why we would need to add to it?

[sbordet]

@janbartel it's not a problem, just I don't like it because it is only ever used in that one place for the encoding, all other places don't have "default" in it.

As to your question about webdefault.xml, I don't see why we would need to add to it?

I was asking whether we must provide a default or not - apparently not.
webdefault.xml was the only other place I thought could be affected by this change, so I asked.