Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for OpenID #4610

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Docs for OpenID #4610

merged 2 commits into from
Feb 27, 2020

Conversation

WalkerWatch
Copy link
Contributor

Creates documentation based off #4123 for OpenID.

@WalkerWatch
Copy link
Contributor Author

@lachlan-roberts Can you give this a read over? For brevity I only listed two OpenID providers (Google and Amazon), as I figured they were the most common. Also, I wanted to verify nothing had changed since your last comments on the issue.

Copy link
Contributor

@lachlan-roberts lachlan-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me.

Now that we have embedded-guide and distribution-guide do we need to split up the openid information relating to embedded and the distribution into the two separate guides?

@WalkerWatch
Copy link
Contributor Author

@lachlan-roberts Yeah, but that will be part of a bigger effort across multiple parts of the documentation. For now I just want to get the content in.

@WalkerWatch WalkerWatch merged commit da9ec6f into jetty-10.0.x Feb 27, 2020
@WalkerWatch WalkerWatch deleted the jetty-10.0.x-openiddocs branch February 27, 2020 03:27
lachlan-roberts added a commit that referenced this pull request Mar 1, 2020
Co-authored-by: Lachlan <lachlan@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants