websocket JPMS fixes to not export websocket-core #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
commented
Mar 13, 2020
| @@ -23,11 +23,11 @@ | |||
| module org.eclipse.jetty.websocket.javax.client | |||
| { | |||
| exports org.eclipse.jetty.websocket.javax.client; | |||
| exports org.eclipse.jetty.websocket.javax.client.internal to org.eclipse.jetty.websocket.javax.server; | |||
There was a problem hiding this comment.
@sbordet This is a weird case, I needed this because websocket-javax-server needs to extend on websocket-javax-client but we still don't want to transitively export our classes which have websocket-core in the signature.
This gives an error
Warning:(26, 99) java: module not found: org.eclipse.jetty.websocket.javax.server
I'm guessing this is because this module is complied before the websocket-javax-server module or something like that.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websocket-jetty-serverandwebsocket-jetty-clientwere transitively exportingwebsocket-jetty-commonwhich transitively exportswebsocket-coreandwebsocket-util.The same issue was with the javax side.
These changes make it so that the jetty & javax client and server modules do not export their common modules and therefore do not transitively export
websocket-coreandwebsocket-util.