Issue #4691 - Use MethodHandles.lookup() consistently in WebSocket code. #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using MethodHandles.publicLookup().in(...) instead of privateLookupIn(...). * Moved test WebSocket EndPoint classes into the proper package, otherwise they would not be accessible because the test package is not exported. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@lachlan-roberts please review. Note that this is the minimal change needed for 10.0.0.alpah2, but the issue is not completed because You want to keep the issue open, merge this PR, but create another PR to fix the issue. |
lachlan-roberts
approved these changes
Mar 23, 2020
| @@ -706,16 +706,7 @@ private void assertSignatureValid(Class<?> endpointClass, Method method, Class<? | |||
|
|
|||
| private MethodHandles.Lookup getMethodHandleLookup(Class<?> endpointClass) throws InvalidWebSocketException | |||
There was a problem hiding this comment.
Can remove the throws InvalidWebSocketException now.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they would not be accessible because the test package is not exported.
Signed-off-by: Simone Bordet simone.bordet@gmail.com
#4691