Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4697 ServletContext sessionModes methods should throw UnsupportedOperationException #4698

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

janbartel
Copy link
Contributor

Closes #4697

A ServletContextListener that has been added programmatically should obtain an UnsupportedOperationException when calling ServletContext.getDefaultSessionTrackingModes, ServletContext.getEffectiveSessionTrackingModes and ServletContext.setSessionTrackingModes.

…tedOperationException

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel added Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Mar 23, 2020
@janbartel janbartel requested a review from olamy March 23, 2020 14:57
@janbartel janbartel self-assigned this Mar 23, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
sce.getServletContext().getDefaultSessionTrackingModes();
sce.getServletContext().setAttribute("MyContextListener.defaultSessionTrackingModes", Boolean.FALSE);
}
catch (UnsupportedOperationException e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using assertThrows?

@olamy olamy self-requested a review March 25, 2020 02:44
@janbartel janbartel merged commit 57324f3 into jetty-10.0.x Mar 25, 2020
@joakime joakime deleted the jetty-10.0.x-4697-sessionmodes-tck branch May 21, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default and EffectiveSessionTrackingModes should throw UnsupportedOperationException
2 participants