Issue #4765 - Review GzipHandler inside ServletContextHandler. #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed GzipHandler from ServletContextHandler. Updated ServletContextHandlerTest. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Fixed test failures. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
requested changes
Apr 14, 2020
| /** | ||
| * @param gzipHandler The {@link GzipHandler} to set on this context. | ||
| */ | ||
| public void setGzipHandler(GzipHandler gzipHandler) |
There was a problem hiding this comment.
I think we should leave the get and set methods, but deprecate them. The implementation can be replaced by an insert handler call
| @@ -90,7 +90,7 @@ public void setUp() throws Exception | |||
|
|
|||
| GzipHandler gzipHandler = new GzipHandler(); | |||
| gzipHandler.setMinGzipSize(16); | |||
| tester.getContext().insertHandler(gzipHandler); | |||
| tester.getServer().insertHandler(gzipHandler); | |||
There was a problem hiding this comment.
This is not the equivalent test. it should be tester.getContext().insertHandler(gzipHandler);
There was a problem hiding this comment.
perhaps test gzip in and outside of the context?
Fixed XML files. Restored ServletContextHandler.setGzipHandler() and deprecated it in case it's used from user's XML files. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Restored IncludedGzipTest. Fixed ServletContextHandler.relinkHandlers(), now excluding the checks for GzipHandler. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed GzipHandler from ServletContextHandler.
Updated ServletContextHandlerTest.
Signed-off-by: Simone Bordet simone.bordet@gmail.com
Closes #4765.