Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4825 - Implement spec requirements for Request.newPushBuilder #4829

Merged
merged 5 commits into from
May 1, 2020

Conversation

janbartel
Copy link
Contributor

Closes #4825

Implement spec for javax.servlet.http.PushBuilder according to the javadoc, and as tested for by the tck.

Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel added Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Apr 29, 2020
@janbartel janbartel requested a review from sbordet April 29, 2020 16:27
@janbartel janbartel self-assigned this Apr 29, 2020
Signed-off-by: Jan Bartel <janb@webtide.com>
continue;
switch (header)
{
case SET_COOKIE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can easily coalesce the null-check and the switch into a single if (header == SET_COOKIE).
How about SET_COOKIE2 (I'm ok to not consider it, just raising the issue of whether we want to explicitly not consider it).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set-Cookie2 is an actual header from a valid spec.
https://tools.ietf.org/html/rfc2965

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel requested a review from sbordet April 29, 2020 21:44
@janbartel janbartel merged commit f154151 into jetty-10.0.x May 1, 2020
@janbartel janbartel deleted the jetty-10.0.x-4825-pushbuilder branch May 1, 2020 09:07
@joakime joakime changed the title Jetty 10.0.x 4825 pushbuilder Issue #4825 - Implement spec requirements for Request.newPushBuilder May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PushBuilder tck test failures
4 participants