Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jnr-unixsocket from 0.24 to 0.34 #5190

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 24, 2020

Bumps jnr-unixsocket from 0.24 to 0.34.

Commits
  • 14ab8d5 [maven-release-plugin] prepare release jnr-unixsocket-0.34
  • db29249 [maven-release-plugin] prepare for next development iteration
  • 57f2197 [maven-release-plugin] prepare release jnr-unixsocket-0.33
  • 431bb9f Update jnr-posix
  • e8a4f61 [maven-release-plugin] prepare for next development iteration
  • 14d78b1 [maven-release-plugin] prepare release jnr-unixsocket-0.32
  • cff7115 Update jnr-posix
  • e6cddcf Update jnr-ffi and jnr-enxio
  • ffb6b0a [maven-release-plugin] prepare for next development iteration
  • cfcc464 [maven-release-plugin] prepare release jnr-unixsocket-0.31
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jnr-unixsocket](https://github.com/jnr/jnr-unixsocket) from 0.24 to 0.34.
- [Release notes](https://github.com/jnr/jnr-unixsocket/releases)
- [Commits](jnr/jnr-unixsocket@jnr-unixsocket-0.24...jnr-unixsocket-0.34)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 24, 2020
@olamy
Copy link
Member

olamy commented Aug 24, 2020

The build failed due to an enforcer rule?

[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java) @ jetty-unixsocket-common ---
[WARNING] Rule 3: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.github.jnr:jnr-ffi:2.1.15 paths to dependency are:
+-org.eclipse.jetty:jetty-unixsocket-common:10.0.0-SNAPSHOT
  +-com.github.jnr:jnr-unixsocket:0.34
    +-com.github.jnr:jnr-ffi:2.1.15
and
+-org.eclipse.jetty:jetty-unixsocket-common:10.0.0-SNAPSHOT
  +-com.github.jnr:jnr-unixsocket:0.34
    +-com.github.jnr:jnr-enxio:0.28
      +-com.github.jnr:jnr-ffi:2.1.15
and
+-org.eclipse.jetty:jetty-unixsocket-common:10.0.0-SNAPSHOT
  +-com.github.jnr:jnr-unixsocket:0.34
    +-com.github.jnr:jnr-posix:3.0.59
      +-com.github.jnr:jnr-ffi:2.1.16
]

Also, if this is accepted, the associated unixsocket.mod needs to be updated to reference these new lib versions too.

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Member

olamy commented Aug 25, 2020

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 25, 2020

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@olamy olamy requested a review from joakime August 25, 2020 08:28
@olamy
Copy link
Member

olamy commented Aug 25, 2020

@joakime upperBound fixed

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough change, build failure is a flaky test being fixed in an unrelated PR.

@olamy olamy merged commit 8951163 into jetty-10.0.x Sep 1, 2020
@olamy olamy deleted the dependabot/maven/com.github.jnr-jnr-unixsocket-0.34 branch September 1, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants