Fixes #5217 - Review RoundRobinConnectionPool #5219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced IndexedConnectionPool and RandomConnectionPool. Clarified semantic of RoundRobinConnectionPool. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
requested changes
Sep 1, 2020
|
|
||
| private final Pool<Connection> pool; | ||
|
|
||
| public IndexedConnectionPool(HttpDestination destination, int maxConnections, boolean cache, Callback requester, int maxMultiplex) |
There was a problem hiding this comment.
I think the cache should be forced to false, otherwise you risk reaching a steady state where one thread continuously uses the connection at the same index.
There was a problem hiding this comment.
I think there shouldn't be a cache and it should be replaced by round robin: see #5218
gregw
reviewed
Sep 1, 2020
jetty-client/src/main/java/org/eclipse/jetty/client/RoundRobinConnectionPool.java
Outdated
Show resolved
Hide resolved
Updates after review. Fixed broken tests. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced IndexedConnectionPool and RandomConnectionPool.
Clarified semantic of RoundRobinConnectionPool.
Signed-off-by: Simone Bordet simone.bordet@gmail.com