Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump asm.version from 8.0.1 to 9.0 #5349

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 28, 2020

Bumps asm.version from 8.0.1 to 9.0.
Updates asm-commons from 8.0.1 to 9.0

Updates asm from 8.0.1 to 9.0

Updates asm-tree from 8.0.1 to 9.0

Updates asm-analysis from 8.0.1 to 9.0

Updates asm-util from 8.0.1 to 9.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 28, 2020
@joakime
Copy link
Contributor

joakime commented Sep 28, 2020

@janbartel do we want this from Jetty 9.4.x onwards?
Or from Jetty 10 onwards (like this PR shows?)

I realize we are still waiting on the CQ/PR for this.

@joakime
Copy link
Contributor

joakime commented Sep 30, 2020

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/jetty-10.0.x/asm.version-9.0 branch from 74de3fd to 9220ed7 Compare September 30, 2020 18:51
@joakime
Copy link
Contributor

joakime commented Oct 8, 2020

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2020

Looks like these dependencies are up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Oct 8, 2020
@dependabot dependabot bot deleted the dependabot/maven/jetty-10.0.x/asm.version-9.0 branch October 8, 2020 14:53
@joakime
Copy link
Contributor

joakime commented Oct 8, 2020

@dependabot rebuild

@joakime joakime restored the dependabot/maven/jetty-10.0.x/asm.version-9.0 branch October 8, 2020 19:28
@joakime
Copy link
Contributor

joakime commented Oct 8, 2020

The upgrade to ASM 9.0.0 is not possible (yet) as it breaks Aries SpiFly 1.3.0.

@joakime joakime reopened this Oct 8, 2020
@joakime
Copy link
Contributor

joakime commented Oct 8, 2020

@dependabot rebuild

@dependabot dependabot bot force-pushed the dependabot/maven/jetty-10.0.x/asm.version-9.0 branch from 9220ed7 to ce77b4d Compare October 8, 2020 19:29
@joakime
Copy link
Contributor

joakime commented Oct 8, 2020

This is fixed in aries / spifly codebase already, but there's no release for it (yet).

Commit at aries that fixed for ASM 9.0 - apache/aries@d110436

Issue tracking ASM 9.0: https://issues.apache.org/jira/browse/ARIES-2008

Bumps `asm.version` from 8.0.1 to 9.0.

Updates `asm-commons` from 8.0.1 to 9.0

Updates `asm` from 8.0.1 to 9.0

Updates `asm-tree` from 8.0.1 to 9.0

Updates `asm-analysis` from 8.0.1 to 9.0

Updates `asm-util` from 8.0.1 to 9.0

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/jetty-10.0.x/asm.version-9.0 branch from ce77b4d to d305ca3 Compare October 12, 2020 13:51
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy olamy merged commit 58a84f2 into jetty-10.0.x Oct 16, 2020
@olamy olamy deleted the dependabot/maven/jetty-10.0.x/asm.version-9.0 branch October 16, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants