Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5320 - using jetty-websocket-httpclient.xml within webapp #5374

Merged
merged 13 commits into from
Nov 2, 2020

Conversation

lachlan-roberts
Copy link
Contributor

Issue #5320

Run the jetty-websocket-httpclient.xml with server class access if WebAppClassLoader is available.

…t in webapp

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…cess.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts marked this pull request as ready for review October 6, 2020 03:23
@lachlan-roberts lachlan-roberts requested review from gregw and sbordet and removed request for gregw October 6, 2020 03:31
@lachlan-roberts
Copy link
Contributor Author

@sbordet you asked me to add the case where we provide the websocket client classes in WEB-INF/lib, but the webapp still uses the server versions of org.eclipse.jetty.websocket. classes. So it is basically unusable, I get ClassCastException and LinkageError.

Don't you use some shaded jars in cometd to get around this problem?

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…client.xml

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…20-WebSocketHttpClient

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@@ -42,10 +37,8 @@

public class WebSocketExtensionFactory extends ExtensionFactory implements LifeCycle, Dumpable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class extends a deprecated class -- should this class be deprecated as well?

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using WebSocketClient with jetty-websocket-httpclient.xml in a Jetty web application causes ClassCastException
2 participants