Better support for implied ports on ForwardedRequestCustomizer #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw
requested changes
Oct 12, 2020
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
jetty-server/src/test/java/org/eclipse/jetty/server/ForwardedRequestCustomizerTest.java
Outdated
Show resolved
Hide resolved
gregw
reviewed
Oct 12, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/ForwardedRequestCustomizer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw
approved these changes
Oct 13, 2020
joakime
referenced
this pull request
Oct 13, 2020
+ Merge ProxyPass tests from CheckReverseProxyHeadersTest into ForwardedRequestCustomizerTest + Deleted CheckReverseProxyHeadersTest.java + Add more tests for ForcedHost configuration + Updated ForwardedRequestCustomizer to conform to expectations Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
changed the title
3 tasks
oleg-nenashev
added a commit
to jenkinsci/winstone
that referenced
this pull request
Oct 19, 2020
Picks up https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.33.v20201019 which includes a fix for jetty/jetty.project#5417 fix is out (PR: jetty/jetty.project#5419 )
olamy
pushed a commit
to jenkinsci/winstone
that referenced
this pull request
Oct 23, 2020
Picks up https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.33.v20201019 which includes a fix for jetty/jetty.project#5417 fix is out (PR: jetty/jetty.project#5419 )
olamy
added a commit
to jenkinsci/winstone
that referenced
this pull request
Oct 26, 2020
…020 (#124) * [JENKINS-63958] - Update Jetty from 9.4.32.v20200930 to 9.4.33.v20201019 Picks up https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.33.v20201019 which includes a fix for jetty/jetty.project#5417 fix is out (PR: jetty/jetty.project#5419 ) * Update parent POM * jetty version is 9.4.33.v20201020 Signed-off-by: olivier lamy <olamy@apache.org> * parent 1.59 is broken argLine Signed-off-by: olivier lamy <olamy@apache.org> Co-authored-by: olivier lamy <olamy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5417
Implied ports were taken from the active connector's HttpConfiguration, this was a bad idea.
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com