Fix archive assemblies (tar.gz and zip) to have fixed file/dir modes. #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Not taking the modes from whatever defaults the filesystem that ran the build is currently on. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
olamy
approved these changes
Oct 17, 2020
gregw
requested changes
Oct 19, 2020
Comment on lines
18
to
19
| <fileMode>0444</fileMode> | ||
| <directoryMode>0755</directoryMode> |
There was a problem hiding this comment.
I think the following would be better:
Suggested change
| <fileMode>0444</fileMode> | |
| <directoryMode>0755</directoryMode> | |
| <fileMode>0400</fileMode> | |
| <directoryMode>0700</directoryMode> |
We should not be granting any permissions to groups or others
There was a problem hiding this comment.
Also should we set 0800 for the files in bin?
There was a problem hiding this comment.
good points.
I was rather happy that these modes I started with had no issue in the /test-distribution/ already.
Wonder if we should expand those tests to use the bin/jetty.sh too (in some regard)?
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
@gregw can I get a re-review? the modes have been updated. |
gregw
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that ran the build is currently on.
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com